[macports-ports] 02/02: fcron: on High Sierra, set permissions to allow binaries to work

[Ryan Schmidt]

On Oct 1, 2017, at 11:36, Kurt Hindenburg wrote:

> Kurt Hindenburg (kurthindenburg) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/afc5e1f85dc22dc882ee232b57cbbad9ac6e007f
> 
> commit afc5e1f85dc22dc882ee232b57cbbad9ac6e007f
> 
> Author: Kurt Hindenburg <khindenburg at macports.org>
> AuthorDate: Sun Oct 1 12:34:57 2017 -0400
> 
> 
>     fcron: on High Sierra, set permissions to allow binaries to work

Can you explain why this was necessary?

The same problem was reported and fixed the same way for sudo:

https://trac.macports.org/ticket/54958

Is there a bug in MacPorts or High Sierra or APFS or the install program related to sticky bits?



>  post-destroot {
> +    if {${os.major} >= 17} {
> +        file attributes ${destroot}${prefix}/sbin/fcron -permissions +s
> +        file attributes ${destroot}${prefix}/bin/fcrontab -permissions +s
> +        file attributes ${destroot}${prefix}/bin/fcrondyn -permissions +s
> +        file attributes ${destroot}${prefix}/bin/fcronsighup -permissions +s
> +    }
> +

> @@ -56,8 +70,7 @@ starting ${name} with launchd. It is disabled\
>  by default. Execute the following command to start it,\
>  and to cause it to launch at startup:
>  
> -sudo launchctl load -w ${startup_root}/Library/LaunchDaemons/org.macports.fcron.plist
> -
> +sudo port load fcron

Instructions for loading the plist are printed twice. Can we remove the duplicate copy of the instructions that the port prints?


$ sudo port install fcron +universal
--->  Computing dependencies for fcron
--->  Fetching archive for fcron
--->  Attempting to fetch fcron-3.2.1_1+universal.darwin_16.i386-x86_64.tbz2 from https://packages.macports.org/fcron
--->  Fetching distfiles for fcron
--->  Attempting to fetch fcron-3.2.1.src.tar.gz from http://fcron.free.fr/archives
--->  Verifying checksums for fcron
--->  Extracting fcron
--->  Configuring fcron
--->  Building fcron
--->  Staging fcron into destroot
--->  Creating launchd control script
###########################################################
# A startup item has been generated that will aid in
# starting fcron with launchd. It is disabled
# by default. Execute the following command to start it,
# and to cause it to launch at startup:
#
# sudo port load fcron
###########################################################
--->  Installing fcron @3.2.1_1+universal
--->  Activating fcron @3.2.1_1+universal
--->  Cleaning fcron
--->  Some of the ports you installed have notes:
  fcron has the following notes:
    Before starting fcron, create the configuration file /opt/local/etc/fcron.conf by using /opt/local/etc/fcron.conf.sample as a reference.
    
    Before starting fcron, create the file /opt/local/etc/fcron.allow by using /opt/local/etc/fcron.allow.sample as a reference.
    
    A startup item has been generated that will aid in starting fcron with launchd. It is disabled by default. Execute the following command to start
    it, and to cause it to launch at startup:
    
    sudo port load fcron