Instructions for creating patches (Re: trac rrdtool)

Mojca Miklavec mojca at macports.org
Thu May 3 06:51:49 UTC 2018


On 1 May 2018 at 16:11, Rainer Müller wrote:
>
> The guide uses "Portfile-rrdtool.diff" as an example filename [1]. Some
> users seem to take that literally and submit patches with that name.
>
> [1] https://guide.macports.org/#development.patches.portfile

Looking at this part of the guide, I would suggest that we change the
instructions. It almost definitely makes more sense to use "git diff
..." instead of "diff ...", but more importantly we probably want to
suggest creating a pull request at that point anyway.

Mojca


More information about the macports-dev mailing list