One large pull request vs. several small ones?

[Ruben Di Battista]

I think the best approach is to isolate “atomic” changes, and open a PR for each of them. This way problems with dependencies can be isolated and decoupled from those for Blender. 

If they are really too many, maybe try to provide PRs for semantically related libraries or somehow related in some other way (like, “python” dependencies). I would say a maximum of 3 - 4 ports per PR? 

I’ll leave the word to more expert members of the community, that’s my general approach when I need to merge upstream complex trees of ports...

          _   
-.     .´  |∞∞∞∞
  ',  ;    |∞∞∞∞∞∞
    ˜˜     |∞∞∞∞∞∞∞∞∞ RdB
    ,.,    |∞∞∞∞∞∞
  .'   '.  |∞∞∞∞
-'       `’

https://rdb.is

On 12 May 2020 at 19:45:30, Jason Liu (jasonliu at umich.edu) wrote:

I would like to contribute a portfile for the newest version of Blender. I already have a local portfile that is compiling successfully, and I am doing some cleanup before submitting a pull request on GitHub. In addition to Blender itself, I have also packaged several of Blender's dependent libraries, which would also be new ports. My question is: Would it be better for me to submit all of the portfiles for Blender and the libraries in one single pull request? Or should I submit one pull request for each new package individually?

The reason why I ask is that the dependency tree is a bit complex, with some of the libraries dependent on other libraries which I packaged as well. And if I were to submit each of the libraries individually, there's no telling how long it would take to get each one of them accepted and merged before I would be able to submit the Blender portfile.

-- 
Jason Liu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macports.org/pipermail/macports-dev/attachments/20200512/e2aa128f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP using AMPGpg
URL: <http://lists.macports.org/pipermail/macports-dev/attachments/20200512/e2aa128f/attachment.sig>